Adds the limit for the deferred stream's queue size #6852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6852 +/- ##
==========================================
- Coverage 73.15% 73.13% -0.02%
==========================================
Files 2499 2499
Lines 126162 126170 +8
==========================================
- Hits 92292 92273 -19
- Misses 33870 33897 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We still have this on the back log. I will soon start work on the defer / stream part and then we will have a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with streaming: if the rate of consuming data by the client is slower than the rate of streaming data by the server, the server prefetches too much data from the source.
Proposed solution is to limit the queue size (size of the result buffer) in
DeferredWorkState.Changes:
DeferredWorkStatehas a limit now;DeferredExecutionTaskis unbound from its starting with newTaskDispatcherclass;DeferredExecutionTaskhas to complete before starting the new one inDeferredStream.