Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #6818

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Various improvements #6818

wants to merge 9 commits into from

Conversation

AntonC9018
Copy link
Contributor

  • Make a few helper classes public
  • Fix some formatting
  • Use utf8 literals

@glen-84

This comment was marked as outdated.

Copy link

github-actions bot commented Jan 16, 2024

Qodana for .NET

3 new problems were found

Inspection name Severity Problems
Use preferred style for trailing comma before new line in multiline lists 🔴 Failure 1
Use preferred braces style (enforce braces in 'for' statement) 🔴 Failure 1
Type member is never used (private accessibility) 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (584b932) 70.89% compared to head (8ad1825) 70.88%.
Report is 3 commits behind head on main.

Files Patch % Lines
...tCore/Extensions/EndpointRouteBuilderExtensions.cs 88.88% 2 Missing ⚠️
...e/Client/src/Core/Serialization/Iso8601Duration.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6818      +/-   ##
==========================================
- Coverage   70.89%   70.88%   -0.01%     
==========================================
  Files        2520     2520              
  Lines      126678   126686       +8     
==========================================
- Hits        89805    89799       -6     
- Misses      36873    36887      +14     
Flag Coverage Δ
unittests 70.88% <92.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants