Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition Improvements #6667

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 3, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (a2da93b) 63.92%.
Report is 81 commits behind head on main.

Files Patch % Lines
...rization.Opa/Request/DefaultQueryRequestFactory.cs 0.00% 3 Missing ⚠️
...Abstractions/Serialization/Utf8JsonWriterHelper.cs 40.00% 3 Missing ⚠️
.../Transport.Http/GraphQLHttpEventStreamProcessor.cs 92.10% 3 Missing ⚠️
...AspNetCore/src/Transport.Http/GraphQLHttpClient.cs 71.42% 2 Missing ⚠️
...Core/Serialization/DefaultHttpResponseFormatter.cs 0.00% 1 Missing ⚠️
...pNetCore/src/Transport.Http/GraphQLHttpResponse.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6667       +/-   ##
===========================================
- Coverage   78.98%   63.92%   -15.06%     
===========================================
  Files        2903     2324      -579     
  Lines      139771   114624    -25147     
===========================================
- Hits       110397    73276    -37121     
- Misses      29374    41348    +11974     
Flag Coverage Δ
unittests 63.92% <81.15%> (-15.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant