Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in a naming convention for generic arguments #6547

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AntonC9018
Copy link
Contributor

This one is kind of a blocker for me. In my use case, I need to prefix all type names that come from a certain namespace. I have come across the class DefaultNamingConventions which allows this if you override it, but the problem is that it doesn't do so recursively, that is, it doesn't use GetTypeName for the generic arguments of the type.

I decided to make the implementation non-breaking, so that it has a better chance to get into the upstream quicker.

@github-actions
Copy link

HotChocolate.Fusion.Composition.DescriptionMergeTests.Output_Rewrite_Nullability_For_Output_Types [FAIL]

@github-actions
Copy link

HotChocolate.Fusion.Composition.DescriptionMergeTests.Output_Rewrite_Nullability_For_Output_Types [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.Depth_Analysis_Overrides_Are_Not_Cached [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.ClassDataLoader_Resolve_From_DependencyInjection [FAIL]

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@980cbbe). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6547   +/-   ##
=======================================
  Coverage        ?   78.78%           
=======================================
  Files           ?     2920           
  Lines           ?   140537           
  Branches        ?        0           
=======================================
  Hits            ?   110722           
  Misses          ?    29815           
  Partials        ?        0           
Flag Coverage Δ
unittests 78.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant