Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package reference in export.socrata #140

Closed
geneorama opened this issue May 15, 2017 · 4 comments
Closed

Fix package reference in export.socrata #140

geneorama opened this issue May 15, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@geneorama
Copy link
Member

Adding issue per discussion in analytics meeting today

export.socrata has a call to file_ext, but it should be tools::file_ext because tools is not in the default search path. https://github.com/Chicago/RSocrata/blob/dev/R/RSocrata.R#L508

I think it's sufficient to simply add tools:: because tools is a default package. I don't think it needs to be added in the IMPORTS or DEPENDS fields in DESCRIPTION.

@tomschenkjr tomschenkjr added the bug label Jun 6, 2017
@tomschenkjr tomschenkjr added this to the 1.7.4 milestone Dec 4, 2017
@geneorama
Copy link
Member Author

@tomschenkjr I can't add this to 1.7.4 because the code is only in branch issue126

@tomschenkjr
Copy link
Contributor

Got it, so only related to #126?

I've reassigned this issue to the v1.8.0 milestone. Since you're looking at it, can you make the change in issue126? Feel free to directly push to it.

@tomschenkjr tomschenkjr modified the milestones: 1.7.4, 1.8.0 Dec 4, 2017
@geneorama
Copy link
Member Author

I'm not sure why that commit message didn't close this issue, but I'm closing it now.

@tomschenkjr
Copy link
Contributor

tomschenkjr commented Dec 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants