feat: add option to suppress live notifications on startup #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
feat/suppress-live-on-start
branch
from
ae9a252
to
6f03b65
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
also closes #3411 |
Nerixyz
force-pushed
the
feat/suppress-live-on-start
branch
2 times, most recently
from
b44dc59
to
c132c62
Compare
Nerixyz
force-pushed
the
feat/suppress-live-on-start
branch
from
c132c62
to
29daaf2
Compare
Nerixyz
commented
May 14, 2024
| namespace chatterino { | ||
|
|
||
| /// Case insensitive transparent comparator for Qt's string types | ||
| struct QCompareCaseInsensitive { |
There was a problem hiding this comment.
I'm going to use this for LinkParser in a future PR to remove the last allocation it does while parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to suppress the initial live notification (🤓 but the title says "startup"). An initial live notification is a notification resulting from the first encountered live status update in a TwitchChannel and a fake channel (both are independent). A change could be the application starting up, but it's also a channel being joined for the first time or a channel going from TwitchChannel → fake or the other way around. I think having "startup" as the title of the option is clear enough.
Additionally, some inconsistencies have been fixed (e.g. streamer mode not suppressing toasts, toasts from fake channels not having a title, ...). TwitchChannel and fake channels now use the same implementation to send notifications.
Closes #3006.
I'm waiting for #4868, so I'll mark this as a draft.