Introduce HTTP API for plugins

[Mm2PL]

This adds a new API: c2.HTTPRequest that requires a new permission: Network.

[github-actions]

clang-tidy made some suggestions

[pajlada]

Design question:
Maybe rename the permission from HTTP to Network? I think this more accurately describes what the plugin will actually be allowed to do, with less of a technical description.
"Allows the plugin to make network requests over your network/over the internet/to third party websites".

Bit of an early review, haven't looked into the implementation of anything

[pajlada]

Data is an iffy name for this. body or text is a more accurate term.

Leaving these fields as methods instead means we could be more flexible when it comes to things like json parsing in the future (see https://docs.rs/reqwest/latest/reqwest/struct.Response.html#implementations)

[Mm2PL]

To put methods on it and have data only in C++-land I'd have to rework HTTPResult to be a shared resource instead of just a table. I'm not sure if this is worth the complexity of that.

[Nerixyz]

The following code segfaults after a short while:

local function send_req()
    local req = c2.HTTPRequest.create(c2.HTTPMethod.Get, "https://postman-echo.com/get")
    req:on_success(function(res)
    end)
    req:on_error(function(result)
    end)
    req:execute()
    c2.later(send_req, 100)
end

send_req()

The crash happens in the handlers of the request. Looking at the captured L, it's probably the thread from c2.later getting deleted while the callbacks hold on to it through lua_State.

[Mm2PL]

The crash happens in the handlers of the request. Looking at the captured L, it's probably the thread from c2.later getting deleted while the callbacks hold on to it through lua_State.

I'll have to store an ID of the plugin or something and get the state back then.

[Mm2PL]

The following code segfaults after a short while:

local function send_req()
    local req = c2.HTTPRequest.create(c2.HTTPMethod.Get, "https://postman-echo.com/get")
    req:on_success(function(res)
    end)
    req:on_error(function(result)
    end)
    req:execute()
    c2.later(send_req, 100)
end

send_req()

The crash happens in the handlers of the request. Looking at the captured L, it's probably the thread from c2.later getting deleted while the callbacks hold on to it through lua_State.

Weird that this only happens with hosts that are remote that is have some latency. Seems like a pesky race condition.

[pajlada]

Let me know when it's in a finished state and I'll take a look