refactor: cleanup and document Scrollbar
#5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because that's what it is.
|
Nice. I could suggest renaming |
4 tasks
|
I added some tests for |
Nerixyz
commented
May 4, 2024
|
I have a couple more things that would be nice to refactor, see Nerixyz#22 :) |
pajlada
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #5329, I realized that
Scrollbarneeded some documentation and a rename oflargeChange. Then I saw some unused functions and clang-tidy warnings, so I decided to refactor the whole class.The commits and documentation should work on their own - if you're missing information, please point that out and I'll add more docs.
Since I added some documentation, I decided to add a
doxygentarget (if available), so I don't have to re-add that every time I want to generate documentation. It's not meant to be pretty - we could use breathe for that. But it's not really a priority since Chatterino isn't a library.