refactor: load Twitch emotes from Helix #5239
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably not a fix, but for a user it's a fix.
This PR refactors how Twitch emotes are loaded - using the new Helix API.
As it refactors quite a bit of stuff, it shouldn't be included in the next release.
Although the API returns decent data, it's slow. For my user (two subscriptions), I need to make 28 requests to get all emotes for one channel. One request takes about 100-250ms. Now imagine how long this would take if a user has 50 (or 100) channels open and more subscriptions. I don't think it's my implementation (this would generate a report though the slow HTTP handler alerts).
Related twitchdev issues: