Add a UI for uploaded images #4995
Conversation
and all its template implementations
|
Found 2 issues while testing on 097eb7b:
Chatterino2_4995_097eb7b_WindowResizeRepaintingImages.mp4
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // image, path, delete url | ||
|
|
||
| UploadedImage UploadedImageModel::getItemFromRow( | ||
| std::vector<QStandardItem *> &row, const UploadedImage &original) |
There was a problem hiding this comment.
warning: parameter 'row' is unused [misc-unused-parameters]
| std::vector<QStandardItem *> &row, const UploadedImage &original) | |
| std::vector<QStandardItem *> & /*row*/, const UploadedImage &original) |
|
|
||
| img->pixmapOrLoad(); | ||
| // You cannot stop me, clang-tidy | ||
| auto *bleh = const_cast<ImagePtrItemDelegate *>(this); |
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
auto *bleh = const_cast<ImagePtrItemDelegate *>(this);
^| auto *bleh = const_cast<ImagePtrItemDelegate *>(this); | ||
| bleh->ownedImages_[url] = img; | ||
| } | ||
| QSize sizeHint(const QStyleOptionViewItem &option, |
There was a problem hiding this comment.
warning: parameter 'option' is unused [misc-unused-parameters]
| QSize sizeHint(const QStyleOptionViewItem &option, | |
| QSize sizeHint(const QStyleOptionViewItem & /*option*/, |
| bleh->ownedImages_[url] = img; | ||
| } | ||
| QSize sizeHint(const QStyleOptionViewItem &option, | ||
| const QModelIndex &index) const override |
There was a problem hiding this comment.
warning: parameter 'index' is unused [misc-unused-parameters]
| const QModelIndex &index) const override | |
| const QModelIndex & /*index*/) const override |
|
Would it be possible to add the ability to bring up a on-hover pop-up when hovering over the image preview for a better view? Similar to when hovering over emotes and links in chat. |
I'm not sure I like this solution. It requires interaction to just look at an image, where there is no other good 'index' to go by. |
|
TODO
|
…re/image_uploader_ui
…re/image_uploader_ui
This diff is horrendous I am sorry.
This is ic_fluent_image_prohibited_24_regular from Fluenticons
This reverts commit a56d6b0.
| //forget->setText("Remove image from log"); | ||
| buttons->addStretch(); | ||
|
|
||
| auto *view = layout.emplace<QListView>().getElement(); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'QListView' [clang-diagnostic-error]
auto *view = layout.emplace<QListView>().getElement();
^| buttons->addStretch(); | ||
|
|
||
| auto *view = layout.emplace<QListView>().getElement(); | ||
| view->setViewMode(QListView::IconMode); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'QListView' [clang-diagnostic-error]
view->setViewMode(QListView::IconMode);
^| view->setViewMode(QListView::IconMode); | ||
| view->setModel(model); | ||
| view->setIconSize(QSize(96, 96)); | ||
| view->setLayoutMode(QListView::Batched); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'QListView' [clang-diagnostic-error]
view->setLayoutMode(QListView::Batched);
^| view->setModel(model); | ||
| view->setIconSize(QSize(96, 96)); | ||
| view->setLayoutMode(QListView::Batched); | ||
| view->setMovement(QListView::Static); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'QListView' [clang-diagnostic-error]
view->setMovement(QListView::Static);
^| view->setUniformItemSizes(true); | ||
|
|
||
| // without this prop qt throws everything into a single line | ||
| view->setResizeMode(QListView::Adjust); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'QListView' [clang-diagnostic-error]
view->setResizeMode(QListView::Adjust);
^
|
There were complexity complaints related to this PR. They mostly included removing the image preview. However UI-wise an implementation that doesn't load previews might as well just be your text editor. Searching for any image in upload history (for example to repost or delete) is already tedious enough, especially if it's older than a couple of days. IMO this idea is not worth doing without the preview. I'd like to hear feedback on continuing development of this. |
Description
This includes migrations which shouldn't be but might turn out being buggy, use at your own risk.
Ensure that have a backup of your
Logs/ImageUploader.jsonfile.This PR adds a UI that lists all logged images. It also adds a button that forgets an image from the log.
Preview as of 6223e34:
Known issues:
Ill be using
ic_fluent_image_prohibited_24_regular.svgfrom Fluenticons