Implement BTTV Emote Modifiers #4478
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
force-pushed
the
feat/bttv-modifiers
branch
from
d447267
to
e3e1478
Compare
Mm2PL
reviewed
Sep 13, 2023
Comment on lines
+31
to
+48
| if (flags.has(MessageElementFlag::BttvModifierFlipV)) // vertical | ||
| { | ||
| auto scale = QTransform::fromScale(1.0, -1.0); | ||
| auto tl = rect.topLeft(); | ||
| painter.setTransform( | ||
| QTransform::fromTranslate(-tl.x(), -tl.y()) * scale * | ||
| QTransform::fromTranslate(tl.x(), tl.y() + rect.height())); | ||
| return; | ||
| } | ||
|
|
||
| if (flags.has(MessageElementFlag::BttvModifierFlipV)) // horizontal | ||
| { | ||
| auto scale = QTransform::fromScale(-1.0, 1.0); | ||
| auto tl = rect.topLeft(); | ||
| painter.setTransform( | ||
| QTransform::fromTranslate(-tl.x(), -tl.y()) * scale * | ||
| QTransform::fromTranslate(tl.x() + rect.width(), tl.y())); | ||
| } |
There was a problem hiding this comment.
btw this has BttvModifierFlipV twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR implements BTTV's emote modifiers (
w!,h!,v!,z!,!r,!l). They can't be combined. Parsing can be turned off in the settings.See #4470. Implementation is based on night/betterttv@b60d020.