Display message being replied to above input box #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsge
commented
Jan 31, 2023
| @@ -100,7 +101,7 @@ class SplitInput : public BaseWidget | |||
| /// Clears the input box, clears reply thread if inline replies are enabled | |||
| void clearInput(); | |||
|
|
|||
| protected: | |||
| private: | |||
There was a problem hiding this comment.
This was changed at one point during my work on #3722 but was never changed back. Made its way through code review. I noticed it while working on this PR and figured I'd change it back.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Looks fine on Windows for the most part, but the emote picker and close icons are broken. They still work as expected when I click on them. I'll try to debug that this afternoon.
|
dnsge
force-pushed
the
feat/show-message-replying-to
branch
from
ba11ff4
to
dcc6208
Compare
|
I've updated this PR with the latest changes from master. I'm happy with the current state, so I'm marking it as ready for review. Something to decide: should showing the message being replied to be a setting? We could let the user toggle between what happens now (just the "replying to username" text) and this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
When you begin replying to a message (by right-clicking a message and selecting "reply" or clicking the reply button), the message being replied to will now display above the input box.
Example:
In the case of very long messages, the message will be truncated:
Expand for image
The message displayed is uninteractable: you can't click on usernames, highlight text, or see emote tooltips for example. The reply button is hidden and you won't see inline replies if the message you're replying to is also a reply.
The very long message truncation is done using a fixed height limit. This limit was chosen to be big enough for most messages, but we could make it larger/smaller.
Fixes #3897