Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added opening a user's chat in a new tab/split/window with keybinds+click #3766

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added opening a user's chat in a new tab/split/window with keybinds+click #3766

wants to merge 6 commits into from

Conversation

Infinitay
Copy link
Contributor

@Infinitay Infinitay commented May 23, 2022 •
edited

  • CHANGELOG.md was updated, if applicable

The following are the added keybinds for the modifiers required to be held when left clicking a username

Modifier Result
SHIFT Open chat in a new popup
CTRL Open chat in a new tab
ALT Open chat in a new split

Originally was for #2881 but after implementing this and re-reading the request I now realize that #3625 is what the user wanted.

image

@Infinitay
Add opening channels in tab/split via username (Chatterino#2881)
4df320e
@Infinitay
Add WindowManager#openNewChannelWindow to open a pop-up window with a…
cf5fe7d 
… channel

	- Clean up code re-use in place of WindowManager#openNewChannelWindow
@Infinitay
Move logic to ChannelView::handleLinkClick, change modifiers, add pop…
bf51775 
…up support

	- Move changes from 4df320e to ChannelView::handleLinkClick method
	- Now properly opens channels in a new tab or split
	- Add ability to open in a new popup
	- Change keybindings and on middle mouse click to left click
@Infinitay
Remove leftover comment
95f41ab
@Infinitay
Update changelog
943c0cc
kornes
kornes reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@kornes kornes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidenote, not a fan of hardcoding such modifiers, because majority of ppl won't know these exist and there are quite a few already. Maybe adding cheatsheet somewhere in app wouldnt be bad idea :D

src/widgets/helper/ChannelView.cpp Outdated Show resolved Hide resolved
src/singletons/WindowManager.hpp Outdated Show resolved Hide resolved
src/widgets/splits/Split.cpp Outdated Show resolved Hide resolved
@Infinitay
Copy link
Contributor Author

Implemented your suggestions. Thanks for the clarification earlier once again. If someone would like to make further changes such as by creating a proper copy constructor for Split that would be appreciated in replace of the hacky solution in WindowManager#createChannelWindow(Split*)

sidenote, not a fan of hardcoding such modifiers, because majority of ppl won't know these exist and there are quite a few already. Maybe adding cheatsheet somewhere in app wouldnt be bad idea :D

I agree with you, that's why before I made this PR I was looking into our existing hotkeys but noticed it doesn't (yet) support mouse click bindings.

As for a cheatsheet, I was considering adding an unmodifiable entry into existing Hotkeys but not sure if that's how we want to go about things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kornes kornes kornes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Infinitay @kornes