Fix invokeJS crashing when reloading the mod #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rhino's context system is really only a wrapper around some internal thread-local engine state. It's not super important for us to manage in such a fine degree. What's much more important are the scope objects, which are shared by default. The main issue with our previous approach is that when the user executes a "/ct load", we reload the mod from a background thread. This associates the "moduleContext" with that background thread, making future uses of it invalid. The fix is to get rid of all the stored contexts and just call "enterContext" everywhere. The contexts are caches in a thread-local, so it isn't that expensive. We can also batch certain calls in the future.
This can call into engine code, which will lead to a game crash if we are unloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Test packet trigger changes to make sure there are no issues. Also make sure performance isn't impacted