Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments about build options #94

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

MauriceHendrix
Copy link
Contributor

@MauriceHendrix MauriceHendrix commented Apr 4, 2023

Added comments siuggested in closed PR: #73

@MauriceHendrix MauriceHendrix marked this pull request as ready for review April 4, 2023 14:55
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7de7d0a) 99.99% compared to head (c88b587) 100.00%.
Report is 575 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #94     +/-   ##
===========================================
  Coverage    99.99%   100.00%             
===========================================
  Files          931       982     +51     
  Lines        45865     47830   +1965     
===========================================
+ Hits         45862     47830   +1968     
+ Misses           3         0      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -54,6 +54,9 @@ OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
*
*
* For example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CommandLineArguments is to do with passing in arguments to compiled executables. scons used to have an option to "build and run with these command line arguments to the test/executable" but I guess that would now be something to do with ctest if that can actually do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but worth checking with @fcooper8472

@mirams
Copy link
Member

mirams commented Aug 15, 2023

For this to be sorted we want to give advice on how to pass command line arguments to a test executable at the time you write ctest TestBlah....

Some stackoverflow here that looks very complicated! https://stackoverflow.com/questions/28812533/how-to-pass-command-line-arguments-in-ctest-at-runtime

Alternatively, we don't ever do this anymore as you can manually run the test executable and do it directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants