-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added comments about build options #94
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
Coverage 99.99% 100.00%
===========================================
Files 931 982 +51
Lines 45865 47830 +1965
===========================================
+ Hits 45862 47830 +1968
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. |
@@ -54,6 +54,9 @@ OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
* | |||
* | |||
* | |||
* For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CommandLineArguments
is to do with passing in arguments to compiled executables. scons used to have an option to "build and run with these command line arguments to the test/executable" but I guess that would now be something to do with ctest
if that can actually do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, but worth checking with @fcooper8472
For this to be sorted we want to give advice on how to pass command line arguments to a test executable at the time you write Some stackoverflow here that looks very complicated! https://stackoverflow.com/questions/28812533/how-to-pass-command-line-arguments-in-ctest-at-runtime Alternatively, we don't ever do this anymore as you can manually run the test executable and do it directly? |
Added comments siuggested in closed PR: #73