Web3 auth fix #944
Closed
Web3 auth fix #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
juans-chainsafe,
kantagara,
oleksandrchainsafe and
rob1997
sneakzttv
added
the
ready-to-merge
sneakzttv
added
ready-to-merge
juans-chainsafe
requested changes
May 8, 2024
Just in case, I just switch the branch to web3-auth-fix, run the setup.sh and made a webgl build with web3auth login |
|
closing RE conversations with NIkola, this is happening on w3as end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed web3auth issue where it wasn't opening in a new window in webgl. Closes #894
To Test:
Create a webgl build & login with web3auth.