Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle \u inside json parser #483

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

olikraus
Copy link

Issue this pull request references: #477

Changes proposed in this pull request

  • Handle the \u escape inside the json string parser

@RobLoach
Copy link
Contributor

Is this something that could be pushed forwards to SimpleJSON ?

@olikraus
Copy link
Author

Is this something that could be pushed forwards to SimpleJSON ?

Yes the same problem is here also:
https://github.com/nbsdx/SimpleJSON/blob/master/json.hpp#L528

Indeed the conformance report already revealed the problem (section 3, second test):
nbsdx/SimpleJSON#5

So by transfering this pull request to SimpleJSON, the expectation is, that the second test of the string conformance test will succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants