Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS definition to fix #10498 #11964

Merged
merged 2 commits into from
May 1, 2024
Merged

Update TS definition to fix #10498 #11964

merged 2 commits into from
May 1, 2024

Conversation

angrycat9000
Copy link
Contributor

Description

Fixes Typescript definition for Event.raiseEvent to have the correct typing.

Issue number and link

#10498

Testing plan

Create a typescript file with the following code

import {Event} from "@cesium/engine";
const event = new Event<(value:number)=>void>();
event.raiseEvent(3);

Verify that on main, that the last line displays an error.

image

Check out this branch and run npm run build-ts

Verify that no error is displayed now.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • [NA] I have added or updated unit tests to ensure consistent code coverage
  • [NA] I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @angrycat9000!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented May 1, 2024

Thanks @angrycat9000. This looks good to me.

@ggetz ggetz merged commit 55ede3c into main May 1, 2024
10 checks passed
@ggetz ggetz deleted the rest-tuple branch May 1, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants