Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties assigned to wrong object #11933

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix properties assigned to wrong object #11933

merged 1 commit into from
Apr 16, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Apr 15, 2024

Description

Two properties in the Terrain object were set as @memberOf Viewer.prototpye instead of on the Terrain object. I believe this is just a fix of docs and not missing implementation, @ggetz please confirm?

Issue number and link

Fixes #11932

Testing plan

  • run npm run build-docs
  • npm start
  • Check the Viewer docs locally and make sure provider and ready are not defined
  • Check the Terrain docs locally and make sure they do show up there

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz April 15, 2024 15:46
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Apr 16, 2024

Yes, thanks for the fix @jjspace!

@ggetz ggetz merged commit a976575 into main Apr 16, 2024
10 checks passed
@ggetz ggetz deleted the fix-viewer-docs branch April 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewer.ready is undefined
2 participants