Fix Label position height may not be correctly updated when its HeightReference is relative. #11929
+14
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
I noticed Label position height doesn't work anymore when its
HeightReference
is relative since the commit 8e271f1 (diff).This bug might be caused by a premature assignment to
owner._clampedPosition
[1]. As the_clampedPosition
setter ofLabel
clones the inputted value, the following modification for theowner_clampedPosition
won't be applied to the Label glyph billboard [2], which causes the user-specified height not to work as expected. So I moved the assignment to the last line to fix this issue.[1] https://github.com/CesiumGS/cesium/blob/1.116/packages/engine/Source/Scene/Billboard.js#L1141-L1145
[2] https://github.com/CesiumGS/cesium/tree/1.116/packages/engine/Source/Scene/Label.js#L1155-L1172
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my changeCode snippet for reproduction (Sandcastle)