Publish voxel sandcastles #11909
Merged
Publish voxel sandcastles #11909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
ggetz
reviewed
Apr 1, 2024
|
I spotted some warnings in the picking example but I can't reproduce... Might've been a weird one-off but figured I'd comment it |
jjspace
reviewed
Apr 1, 2024
There was a problem hiding this comment.
As far as I can tell the code looks fine and the sandcastles behave as expected apart from the weird bug above that I haven't been able to reproduce.
Given that I don't know the voxel code as well I'd be more confident with a review from @ggetz too given it's release day. Gabby did you wanna merge the change from your comment above?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the two voxel-related Sandcastles from the
/developmentsubfolder into the main/gallery. These Sandcastles will now appear on sandcastle.cesium.com for easier testing and linking from documentation.Along the way, some of the Sandcastle code was cleaned up to remove dead code and use more concise syntax.
The relevant Sandcastles are:
Voxels.html. ThisCustomShaderwas updated to render with transparency, to highlight our support of that feature.VoxelPicking.html. This one renders the voxels fully opaque and demonstrates the lighting capabilities added in #11875.Issue number and link
Resolves #11886.
Testing plan
Load the Voxels and Voxel Picking Sandcastles and verify that the different shapes and input data types are rendered correctly, and that Voxel Picking works, as described in #11828.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change