-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CesiumSunSky date and time properties to Sequencer #761
base: ue4-main
Are you sure you want to change the base?
Conversation
Thanks for the pull request @argallegos!
Reviewers, don't forget to make sure that:
|
There's actually a way to trigger UFUNCTIONs when sequencer-exposed variables are animated on a sequencer track: |
Thanks @xuelongmu, that would be great! |
Thanks again for your contribution @argallegos! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Hi, I tried adding the interp specifiers to the CesiumSunSky script in UE5 to expose the properties but does not reveal them in the sequencer. Are there other changes required to make this work with UE5? |
Adding Interp should work, but only if you recompile the plugin. Unreal won't automatically pick up code changes that you make to an Engine plugin. You can try copying the plugin to your project's Plugins directory instead. |
Great thanks for advice! |
Hi... I'm a newb and so apologize for what is probably a stupid question: How does one find the CesiumSunSky script in UE5, find the interp code necessary to expose the parameter in the sequencer, add the interp code, and then recompile the plugin. Any help you can offer will be hugely appreciated! |
If you've installed the plugin via the Epic Launcher, the code is usually found in |
This is beyond me, could you elaborate with a step-by-step instruction on how to make this work in UE5.3? |
No, we can't provide more detailed instructions than what I've already provided. If you have specific questions we may be able to answer them. Otherwise, you'll have to wait until this is incorporated into an official version of the plugin. |
Thanks for the answers. My specific question is: Is this supposed to also work in UE 5.3.2? On the instructions, the screenshots are for 4.26. |
As far as I know, the approach in this PR should work in 5.3.2 as well, but I haven't tried it. You will have to drag the CesiumSunSky Actor into the Sequencer, though, just like anything else you want to manipulate with the Sequencer. If that doesn't help, I'm afraid I don't know what the problem might be, sorry. |
Maybe I missed something, but what is the way to implement this PR? |
Sorry, I don't understand your question. |
See #760 - Previously, you could not animate the date or time in Sequencer. This PR exposes CesiumSunSky's Solar Time, Day, Month, Year, and Time Zone parameters to Sequencer.
Note that currently, CesiumSunSky's
UpdateSun
function must be called every frame in order for the animation to reflect in the scene. The best way I could find around that was to add a Repeater Event Track on CesiumSunSky in the sequencer, then binding that event to UpdateSun. Steps to do that below, since I'm not sure where else to document them:Of course, there's a lot that could be improved here - it would be great if people didn't have to add the event track. But I imagine that would involve refactoring the SunSky so this is probably enough for now.