Fix LOD dithering artifacts #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csciguy8
reviewed
May 6, 2024
|
Unfortunately this does not address #1104. |
This was referenced May 7, 2024
|
Code looks good, and this is working well, no matter if LOD transitions are enabled or disabled. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388, #1359
This PR modifies the ML_DitherFade material layer to prevent some flickering pixels that could be seen on tilesets. These were most visible on Google Photorealistic 3D Tiles, and especially when the tileset was selected. You can see it in
12_CesiumGoogleMapsTilesbehind the intro billboard, or check out #1388 for an example.Before
After
I will also test if this addresses #1104, TBD.