Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CesiumWebMapTileServiceRasterOverlay to match Unity implementation #1397

Merged
merged 6 commits into from
May 23, 2024

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Apr 19, 2024

This was a followup to CesiumGS/cesium-unity#446 that I didn't get a chance to do until now :') From changelog:

  • Renamed the following properties on CesiumWebMapTileServiceRasterOverlay:
    • Url -> BaseUrl
    • West -> RectangleWest
    • South -> RectangleSouth
    • East -> RectangleEast
    • North -> RectangleNorth
  • UseWebMercatorProjection has been deprecated on CesiumWebMapTileServiceRasterOverlay. Instead, use the Projection enum property to specify between Geographic or WebMercator projection.
  • Added TileWidth and TileHeight properties to CesiumWebMapTileServiceRasterOverlay.
  • Fixed a bug where CesiumTileMapServiceRasterOverlay, CesiumWebMapServiceRasterOverlay, and CesiumWebMapTileServiceRasterOverlay would attempt to load empty URLs.

You can test that these changes upgrade seamlessly by:

  1. BEFORE checking out this branch, add a WMTS overlay to Cesium World Terrain. Put some non-default values in the properties.
  2. Check out + build this branch, and reopen the level.
  3. Confirm that the property values were preserved.

@csciguy8 csciguy8 self-requested a review May 21, 2024 17:45
Copy link
Contributor

@csciguy8 csciguy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j9liu !

Code looks great. Verified that old maps load properly and we don't get console spam with empty urls.

Tested using the "USGS Shaded Relief" WMTS in the "Imagery Layers Manipulation" CesiumJS Sandcastle example.

image

@csciguy8 csciguy8 merged commit 9bc9410 into main May 23, 2024
25 checks passed
@csciguy8 csciguy8 deleted the wmts-settings branch May 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants