Added file metadata tests #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 15, 2024 12:31
…ct and registration
This reverts commit ed8cfc6.
jh27539
reviewed
May 13, 2024
jh27539
reviewed
May 13, 2024
jh27539
reviewed
May 13, 2024
jh27539
reviewed
May 13, 2024
…egistration tests from smoke
jh27539
reviewed
May 14, 2024
jh27539
reviewed
May 14, 2024
| registration_metadata_page.scroll_into_view( | ||
| registration_metadata_page.delete_funder_button.element | ||
| ) | ||
| registration_metadata_page.delete_funder_button.click() |
There was a problem hiding this comment.
Selenium expected condition element_to_be_clickable will be helpful here
jh27539
reviewed
May 14, 2024
| project_metadata_page.scroll_into_view( | ||
| project_metadata_page.delete_funder_button.element | ||
| ) | ||
| project_metadata_page.delete_funder_button.click() |
There was a problem hiding this comment.
use a element_to_be_clickable
…under_info method
cslzchen
reviewed
May 14, 2024
cslzchen
reviewed
May 14, 2024
cslzchen
reviewed
May 14, 2024
cslzchen
reviewed
May 14, 2024
cslzchen
reviewed
May 14, 2024
cslzchen
reviewed
May 14, 2024
cslzchen
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the following checks to the selenium test automation suite:
Summary of Changes
Added new test_metadata.py - 6 new tests added to verify title, description, resource type and resource language changes, cancel changes funtionality and download functionality
Updated project.py - added new FilesMetadataPage class , and ProjectMetadataPage class
Updated registries.py - updated RegistrationMetadataPage class
Updated osf_api.py — Added 2 new methods get_fake_file_guid and get_existing_file_data
Updated utils.py - Added 3 new methods verify_file_download, latest_download_file and get_guid_from_url
Reviewer's Actions
git fetch <remote> pull/265/head:feature/test_metadataRun this test using
pytest tests/test_metadata.py -s -vTesting Changes Moving Forward
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-4276
https://openscience.atlassian.net/browse/ENG-4277