Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing TIMERR_NOERROR define #246

Merged

Conversation

jjerphan
Copy link
Contributor

@jjerphan jjerphan commented May 2, 2023

The compilation on Windows is failing due to TIMERR_NOERROR missing as a symbol.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@dwilliamson
Copy link
Collaborator

Can you try including <timeapi.h> instead?

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Copy link
Contributor Author

jjerphan commented Jun 5, 2023

Ah wait, failures on the CI for 4f24480 are not related to those changes.

@dwilliamson: what do you prefer between the state of this branch at 4f24480 and at 96cb8a8?

@dwilliamson
Copy link
Collaborator

RMT_PLATFORM_WINDOWS should imply _WIN32, so I'd prefer 4f24480 if all the tests pass.

Don't worry about any of the spurious build failures, it unfortunately happens a lot with Github :(

@dwilliamson dwilliamson merged commit cb485c9 into Celtoys:main Jun 5, 2023
15 of 17 checks passed
@dwilliamson
Copy link
Collaborator

Thanks, you managed to find the magic include order that passes all the tests that I couldn't find.

(see back story here #172)

Out of interest; what version of VC are you compiling with?

@jjerphan jjerphan deleted the fix/add-missing-TIMERR_NOERROR-define branch June 5, 2023 20:39
@jjerphan
Copy link
Contributor Author

jjerphan commented Jun 6, 2023

Thanks, you managed to find the magic include order that passes all the tests that I couldn't find.

Glad it helped indirectly!

Out of interest; what version of VC are you compiling with?

MSVC 14.29.30133 and MSVC 19.34.31944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants