Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper temperatures for WC and WN stars #913

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GurrenLagannTSS
Copy link
Contributor

@GurrenLagannTSS GurrenLagannTSS commented Feb 5, 2021

Partially implements and closes #901.
Also added temperatures for WNh stars as a workaround, avaiable when using luminosity classes II, I-a, I-b, and I-a0 for WN-class stars.

@375gnu
Copy link
Member

375gnu commented Feb 6, 2021

  1. All commits should be squashed into a single one
  2. Reference to the sources should be left in comments so we can validate temperatures and so on

@Trolligi112477-ww
Copy link

Sources: https://arxiv.org/pdf/1904.04687.pdf
https://arxiv.org/pdf/1807.04293.pdf
Wikipedia
Logic

oh wait... maybe the WN5-WN6 temps should be lowered

@SevenSpheres SevenSpheres self-requested a review February 7, 2021 17:14
@375gnu 375gnu marked this pull request as draft January 25, 2022 22:11
@375gnu 375gnu force-pushed the master branch 2 times, most recently from 690ab56 to 2f8f3b0 Compare May 15, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper WR temperatures
4 participants