Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sets the required standard to C++20 #313

Merged
merged 5 commits into from
Jun 25, 2019
Merged

sets the required standard to C++20 #313

merged 5 commits into from
Jun 25, 2019

Conversation

cjdb
Copy link
Collaborator

@cjdb cjdb commented Jun 24, 2019

CMake was compiling with -std=gnu++1z by default, which apparently causes some strange functionality (see https://godbolt.org/z/g6duRE). This commit sets the minimum standard to the closest standard to either C++2a or C++20 and disables compiler extensions.

cjdb added 3 commits June 24, 2019 23:12
CMake was compiling with `-std=gnu++1z` by default, which apparently causes some strange functionality (see https://godbolt.org/z/g6duRE). This commit sets the minimum standard to the closest standard to either C++2a or C++20 and disables compiler extensions.
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
...which requires cmake 3.12 or greater.
@CaseyCarter
Copy link
Owner

CMake Error in examples/CMakeLists.txt:
  The compiler feature "cxx_std_20" is not known to CXX compiler

  "GNU"

  version 7.3.0.

While we don't precisely need any particular 20 features given support for TS concepts, I'm inclined to cut the cord anyway and drop support for GCC7. "Most recent two compiler releases" is reasonable support for a research tool like cmcstl2.

Opinions?

@cjdb
Copy link
Collaborator Author

cjdb commented Jun 25, 2019

While we don't precisely need any particular 20 features given support for TS concepts, I'm inclined to cut the cord anyway and drop support for GCC7. "Most recent two compiler releases" is reasonable support for a research tool like cmcstl2.

Opinions?

I'm in favour, but I think we'll need to fix #311 first.

@CaseyCarter
Copy link
Owner

I'm in favour, but I think we'll need to fix #311 first.

Actually supporting GCC9 is obviously a prerequisite for GCC9 support; there's no need to make any changes (except to the CI scripts) to drop GCC7 support.

@CaseyCarter CaseyCarter self-requested a review June 25, 2019 18:53
@cjdb cjdb merged commit 8274be4 into CaseyCarter:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants