A0-4224: Extracted pallet alleph runtime API to a separate crate #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggawryal
approved these changes
May 20, 2024
woocash2
approved these changes
May 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor which brings two new crates to
aleph-nodeworkspace:fake-runtime-api, that is used both byfinality-alephandaleph-node(was module inprimitives)pallet-aleph-runtime-api, that is used byaleph-runtimeandfinality-aleph(latter uses just one trait)The motivation is that we want
primitivesto be just bags of costs and types). Also, it follows an upstream approach, e.g., https://github.com/Cardinal-Cryptography/polkadot-sdk/blob/master/substrate/frame/nomination-pools/runtime-api/src/lib.rs