adds card first design-system rules #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonza16
reviewed
Feb 27, 2024
jgonza16
reviewed
Feb 27, 2024
jgonza16
reviewed
Feb 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/1.0.0 #602 +/- ##
===============================================
Coverage 100.00% 100.00%
===============================================
Files 85 85
Lines 1546 1546
Branches 538 538
===============================================
Hits 1546 1546 ☔ View full report in Codecov by Sentry. |
JadhavJeet
force-pushed
the
feature/checkbox-design-system
branch
from
fe0073b
to
a024c90
Compare
daniele-zurico
changed the title
AlaaEddine20
force-pushed
the
feature/checkbox-design-system
branch
from
a024c90
to
415b229
Compare
jgonza16
reviewed
Mar 11, 2024
example/src/components/CardDemo.tsx
Outdated
| @@ -17,6 +17,7 @@ import { faAngleRight } from '@fortawesome/free-solid-svg-icons'; | |||
| import './cardDemo.scss'; | |||
|
|
|||
| export const CardDemo = () => { | |||
| console.log('HELLO'); | |||
There was a problem hiding this comment.
please remove this log
|
|
||
| .dcx-card-image { | ||
| max-width: 100%; | ||
| max-height: 100%; |
There was a problem hiding this comment.
do we want to use any padding here?
padding: .....
There was a problem hiding this comment.
Now we have this gap => column-gap: token('spacing-y-card_box');
jgonza16
force-pushed
the
feature/checkbox-design-system
branch
from
d1dad72
to
4ec2813
Compare
jgonza16
force-pushed
the
feature/checkbox-design-system
branch
from
4ec2813
to
01783fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.