Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolution control option to the config screen #2296

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MeeniMc
Copy link
Contributor

@MeeniMc MeeniMc commented Jan 31, 2024

Adds resolution control (missing option as compared to Vanilla Shift-P options).

fixes #46

The resolution controls would not fit in the allocated space, so I changed the rendering of slidercontrols to enable rendering the slider bar and the value text in the same area.

  1. the slider label is right adjusted
  2. the slider is rendered under the text
  3. the slider is always rendered (opinionated change, don't mind rolling back that part if you don't like it)

The code is mostly new but is liberally inspired from #957 (in particular the setBinding part)

This is how it looks like:
2024-01-31_10 25 23

The resolution controls would not fit in the allocated space, so I
changed the rendering of slidercontrols to enable rendering the slider
bar and the value text in the same area.

Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
reduce the length of scrollbars so that it doesn't look as busy

Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
@MeeniMc MeeniMc changed the title Add resolution control option Add resolution control option to the config screen Jan 31, 2024
@MeeniMc
Copy link
Contributor Author

MeeniMc commented Jan 31, 2024

Note that I did not implement FOV, Distortion, Glint Speed, Glint Strenght, because these are duplicated in the vanilla video options from the accessibility option menu and so are still available without 'tricks'.

Under these assumption that we don't want to re-replicate them, we now have all options covered.

…hat the box can be reduced to avoid overlapping with the undo button.

Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
@MeeniMc
Copy link
Contributor Author

MeeniMc commented Jan 31, 2024

ready for review.

@MeeniMc
Copy link
Contributor Author

MeeniMc commented Mar 7, 2024

updated for mojmap

As for the discussion regarding delaying this after a full config screen refactor, here are some arguments in favor of acting now

  1. users are calling for it on a regular basis (or get confused that the setting is accessible in shift-p which is not intuitive).
  2. the learning curve for users for the new design is very low (looks slightly different, completely equivalent in use, in particular the bounding box for mouse interaction is not changed).
  3. this change should add no complication to said refactor intended to replace it with something better, later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing vanilla graphics settings
1 participant