Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing vanilla graphics settings #46

Closed
2 of 5 tasks
Madis0 opened this issue Jun 30, 2020 · 13 comments · May be fixed by #2296
Closed
2 of 5 tasks

Missing vanilla graphics settings #46

Madis0 opened this issue Jun 30, 2020 · 13 comments · May be fixed by #2296
Labels
T-enhancement Type: Enhancement

Comments

@Madis0
Copy link
Contributor

Madis0 commented Jun 30, 2020

Expected Behavior

Expected all vanilla graphics settings to be available in Sodium.

Actual Behavior

The following graphics settings are missing:

  • Fullscreen Resolution
  • Distortion Effects
  • FOV Effects
  • Entity Shadows
  • Entity Distance

Reproduction Steps

  1. Open Minecraft with Sodium, Settings > Video Settings...
  2. Open vanilla Minecraft, Settings > Video Settings...
  3. Compare the settings

Attachments

N/A

System Information

  • Java Version: 14.0.1 64bit
  • CPU: i7-1065G7
  • GPU: Mesa Iris Plus Graphics
@Madis0 Madis0 added the T-bug Type: Bug label Jun 30, 2020
@Vixtron
Copy link

Vixtron commented Jun 30, 2020

ctrl + shift + p

@Kroppeb
Copy link
Contributor

Kroppeb commented Jun 30, 2020

Just shift+p works too.

@amnotbananaama
Copy link
Contributor

That shortcut does work, but it is not documented leaving new users confused. The ideal solution for me would be either adding a new tab in Sodium's settings with "working vanilla settings" or something, or a button to take you to the vanilla settings screen.

Regarding Jelly's concern that users shouldn't be interacting with the vanilla settings screen because much of it is disabled, we could add some kind of tooltip that many of the vanilla options aren't working, or disable clicking on them outright

@Madis0
Copy link
Contributor Author

Madis0 commented Jun 30, 2020

I thought the goal is to simply transfer all of the vanilla settings to Sodium? Which it mostly already has done, just a few settings to go as outlined in the issue.

@vichvich4444
Copy link

Also no GUI scale if I remember

@Madis0
Copy link
Contributor Author

Madis0 commented Jul 1, 2020

GUI scale exists in 0.1.0

@jellysquid3 jellysquid3 added T-enhancement Type: Enhancement and removed T-bug Type: Bug labels Jul 8, 2020
@Madis0 Madis0 mentioned this issue Aug 3, 2020
This was referenced Aug 7, 2020
@Miros77

This comment has been minimized.

bytzo added a commit to bytzo/sodium-fabric that referenced this issue Mar 1, 2021
Adds distortion effects to the Sodium options page, since it is present in vanilla.
bytzo added a commit to bytzo/sodium-fabric that referenced this issue Mar 1, 2021
Adds FOV effects to the Sodium options page, since it is present in vanilla.
bytzo added a commit to bytzo/sodium-fabric that referenced this issue Mar 3, 2021
Adds distortion effects to the Sodium options page, since it is present in vanilla.
bytzo added a commit to bytzo/sodium-fabric that referenced this issue Mar 3, 2021
Adds FOV effects to the Sodium options page, since it is present in vanilla.
@Eiion
Copy link

Eiion commented Mar 30, 2022

Going back to this issue since for two years it still didn't get implemented:

Please either put a simple line of text, something like:
"To change screen resolution, press Shift+P to open Vanilla settings. But DO NOT make any other changes than resolution since some settings might not work with Sodium"
Or add a resolution slider to the Sodium settings.

Also, from what I recall about the settings, there's also no "Fullscreen" checkbox, yet.

I feel like of all the vanilla settings not included, yet, those are the two most important ones, as these issues are what every new user will immediately - obviously - run into when the game only runs in low resolution window mode and there is no hint about how to make changes to that... other than googling for a solution.

Thanks for considering.

@ghost
Copy link

ghost commented May 2, 2023

A year later, came here to bump because still not implemented and I still google everytime I have a fresh install how to come to the classic menu.

@jellysquid3
Copy link
Member

jellysquid3 commented Mar 7, 2024

The options for "Distortion Effects" and "FOV Effects" will not be added to the Video Settings screen, as these already exist in the Accessibility menu and do not need to be duplicated.

We will also likely not be adding an option to change the fullscreen resolution of the game, and instead will replace it with a "borderless fullscreen" implementation (#2359). This has numerous benefits, but most importantly, it means users will always get the expected behavior by default (the game keeps the existing monitor settings) with better performance and fewer bugs. Doing so also makes implementing support for VRR and HDR much easier.

For people who still really need to change the render resolution (such as to improve performance), we will also be implementing a render scale option (#2362), which has the game render at a lower resolution, while still keeping the monitor configured to the user's settings. Notably, this makes the implementation of advanced upscaling technologies (such as FSR, DLSS, XeSS, etc) possible.

@jellysquid3
Copy link
Member

Seeing that we have other issues open for each of the remaining use cases which otherwise ask for a fullscreen resolution option, this issue is closed.

@Eiion

This comment was marked as off-topic.

@Fnige

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
9 participants