Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

union node validation ensures upstream attributes match Union node name #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JesusGuerrero
Copy link
Collaborator

Signed-off-by: Jesus Rocha jesus.rocha@ibm.com

Signed-off-by: Jesus Rocha <jesus.rocha@ibm.com>
@JesusGuerrero
Copy link
Collaborator Author

Upstream RevenueOfDivision1 has attribute RevenueDivision, and Union (downstream) has label Revenue Division
Screen Shot 2022-12-12 at 1 11 04 PM

Attempting to run the flow at the Union will yield the following message to guide alignment of attributes to union name
Screen Shot 2022-12-12 at 1 11 14 PM

Error above is due to RevenueDivision !== Revenue Division

return {
isValid: false,
error:
'The Union upstream nodes require attribute to be equal to Union name',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesusGuerrero could this error message be made more explicit/detailed? Something like:
`The Union upstream nodes require attribute to be equal to the Union name. Currently, upstream node X has attributes named A, B and C; upstream node Y has attributes Z and ...". All these nodes should have an attribute called "

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this actually introduces a problem because now it is not possible for a node to participate in two union nodes. It's OK for now, but we need to work on #70 to fully address the issue consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants