Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-4009: Change addresses of Examples and clean files #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Dave-Sukharan
Copy link
Contributor

@Dave-Sukharan Dave-Sukharan commented Jan 12, 2021

Fixes BCDA-4009

There were a few typos in the examples of the Metadata section directing users to the sandbox.api endpoints rather than the bcda.api endpoints. There directories left over from the previous version of the site. They are now removed.

Proposed Changes

  • Changed the endpoint URL's in the examples to point to the correct place.
  • Deleted the old site folders including production and sandbox.

Change Details

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications
  • no PHI/PII is affected by this change

Acceptance Validation

Yes.

Screen Shot 2021-01-11 at 8 07 41 PM

Feedback Requested

Dave Sukharan added 2 commits January 11, 2021 18:00
The Build page should not have mention of the sandbox.bcda endpoints in the examples. This fixes a few typos.
Cleaning up the remnants of the old files and extra files.
Copy link
Contributor

@mtrang1263 mtrang1263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants