Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unexpected behavior of get_write_interval #1609

Merged
merged 2 commits into from May 24, 2024

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented May 11, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1606

Issue addresed

This pull request addresses issue #1606 where the get_write_interval function incorrectly returns (0,209) for a packet does not contain captions, implying that caption packets are available from index 0 to 209 which needs to be corrected.

Correction Made

The correction ensures that the correct interval (0,0) is returned, indicating that there are no captions available to write.

Implementation Details

By initialising last variable which stores last caption available by 0

Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just wondering why the CI is failing 🤔

Please wait for @cfsmp3's review.

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented May 14, 2024

LGTM. I'm just wondering why the CI is failing 🤔

Yeah mac CI fails for the hardsubx part which is not even touched

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 2/3
NoCC 10/10
Options 82/86
Teletext 21/21
WTV 0/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit 5748042 into CCExtractor:master May 24, 2024
14 of 15 checks passed
@IshanGrover2004 IshanGrover2004 deleted the fix-get-write-interval-fn branch May 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Unexpected behavior of get_write_interval
4 participants