Strip BOM from ignore files #2178
Conversation
| let rdr = io::BufReader::new(file); | ||
| let rdr = io::BufReader::new( | ||
| DecodeReaderBytesBuilder::new() | ||
| .bom_sniffing(false) |
There was a problem hiding this comment.
I'm not sure if we actually want to enable bom_sniffing here. bom_sniffing(false) seems to be behavior preserving to me. But maybe we want to support ignore files in utf-16 as well?
|
|
||
| fn get_gitignore() -> Gitignore { | ||
| let mut builder = GitignoreBuilder::new("ROOT"); | ||
| let error = builder.add(IGNORE_FILE); |
There was a problem hiding this comment.
I added this as an integration test because the existing unit tests in gitignore.rs don't create any files but the logic to test is in GitignoreBuilder.add which only works on files.
I could also
- either add a unit test that creates a temporary gitignore file,
- or extract a method from
addthat works on aReadand test that. However, since the errors need the path, the extracted method would also need to know the path.
|
Thanks for the work on this. So to me, this is an overpowered solution. I do not think we need to bring in a absolutely enormous dependency on I'm going to close this PR because of its age (and because I'm working through the backlog), but if you want to try this again without |
Fixes #2177