Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript type #122

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix typescript type #122

wants to merge 8 commits into from

Conversation

Bunlong
Copy link
Owner

@Bunlong Bunlong commented Jan 26, 2022

Features

  • Fix typescript type

Issues

@MichielDeMey
Copy link
Contributor

LGTM 👍
We do however need to figure out how to type the props from the render function.

<CSVReader>
{/* How to type these props? */}
{({ getRootProps, acceptedFile, ProgressBar, getRemoveFileProps, Remove }) => (
  return <>Foo</>
)}
</CSVReader>

@Bunlong
Copy link
Owner Author

Bunlong commented Jan 27, 2022 •
edited

@MichielDeMey

Yes, I got it. If you have any more ideas or suggestions please kindly let us know. We very much appreciate for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bunlong @MichielDeMey