Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript type #121

Open
Bunlong opened this issue Jan 26, 2022 · 2 comments
Open

Fix typescript type #121

Bunlong opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Bunlong
Copy link
Owner

Bunlong commented Jan 26, 2022

No description provided.

@Bunlong Bunlong added the bug Something isn't working label Jan 26, 2022
@Bunlong Bunlong self-assigned this Jan 26, 2022
Bunlong added a commit that referenced this issue Jan 26, 2022
Bunlong added a commit that referenced this issue Jan 26, 2022
Bunlong added a commit that referenced this issue Jan 27, 2022
Bunlong added a commit that referenced this issue Jan 29, 2022
Bunlong added a commit that referenced this issue Jan 29, 2022
Bunlong added a commit that referenced this issue Jan 29, 2022
Bunlong added a commit that referenced this issue Jan 29, 2022
@ghost
Copy link

ghost commented Mar 22, 2022

Maybe a silly question, but is this to fix the fact that typing doesn't seem to be working right now? Definitely missing this...

@dr-leevsey
Copy link

Are you planning to add exports to all the related types, not only for main declarations?
In my case I use readString and to type Error properly in my react state I had to write such a cumbersome thing:

type ParseError = Parameters<
  Parameters<ReturnType<typeof usePapaParse>['readString']>[1]['complete']
>[0]['errors'][number];

ofc that works for now, however (apart from the fact this is very odd chunk of code :)) I have absolutely no guarantee that signature will not change in future versions
would be really good to just import that type from react-papaparse module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants