-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setChassisDiscretization #193
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good and exactly what i was looking for! Minor cleanliness things requested. Thank you for making this!!
Renamed the method to push absolute encoder offsets to the encoders as it was poorly named for anything other than attached encoders.
I also renamed the pushOffsets method as we talked about |
Thats a breaking change and it really shouldnt be merged until after the season. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs javadoc descriptions
Addresses #191