Add Cloud Events Attributes to Message Header and Publication. #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancooper
requested review from
holytshirt,
DevJonny and
preardon
as code owners
…irectly, and override usage of the factory if so.
|
Because of the difficulties with merging this code, I have merged into master with the RequestContext. I will then re-open this PR for the open telemetry changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our next step on the path to Cloud Events is to amend the header and publication to contain Cloud Events attributes. As part of this work we are also going to:
Whilst we will amend transport code so that it compiles, this PR won't actually read-write over a given transport, or read-write to a given Outbox. We will raise a set of PRs for those, one per technology, after.