Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapi marten example DRAFT #2076

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

omelianlevkovych
Copy link
Contributor

This is draft pull request to get earlier opinions, thoughts whether I am going into the right direction.

Currently, only the published (GreetingsAPI) is almost completed.
Still luck RMQ setup, outbox patterun support, consumer, migration to net6

Added dummy GreetingsController
Included sln update missed in last commit
Configured Brighter on startup
Created a basic endpoint so it can be used for Marten integration check
…g in the future

Added Marten package and established a simple connection; added fake data to document store
Added docker-compose-postgres with the pgadmin
Updated the GreetingEntityGateway & Startup
Minor refactoring
Updated program class
…into webapi_marten_example

# Conflicts:
#	Brighter.sln
Minor cleanup
@omelianlevkovych
Copy link
Contributor Author

It seems I should do rebase or squash before even creating the PR so the commit history won't be so messy.

@omelianlevkovych omelianlevkovych changed the title Webapi marten example Webapi marten example DRAFT Apr 16, 2022
public class Person
{
public int Id { get; set; }
public ICollection<Greeting> Greetings { get; set; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case I would like to use private setters here so I can follow some DDD/OOP practices; do I have to use reflection somehow so Marten can work with serialization?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how Martin works with serialization, you can try doing private setters and create via constructor and see if it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holytshirt
Copy link
Member

It seems I should do rebase or squash before even creating the PR so the commit history won't be so messy.

Don't work you can always clean up your commits later git rebase master -i and you can squish them.
We'll most likely squish the branch when we merge it into master so don't worry

…into webapi_marten_example

# Conflicts:
#	Brighter.sln
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ omelianlevkovych
❌ OmelianLevkovych


OmelianLevkovych seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants