Multicast, improvements, bug fixes #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fixes: 1) SDES packet header - padding flag must be "false". Fixed. 2) SDES chunk - text length should not include /0. Fixed. 3) SDES reports were sent to RTP port instead of RTCP. Fixed. 4) Since Socket.ReceiveAsync do not natively support cancellation, and receive task was waiting for complete of both RTP and RTCP receive, "normal" cancellation never took place. CloseRtspSessionAsync never called because sockets were closed due to CancelTimeout. As a result, TEARDOWN was never sent. I added WithCancellation task extension and now ReadAsync can be canceled immediately without wait for next incoming packet. I modified only UDP part, but extension can be used in other places too. improvements: 1) "Receiver Report Goodbye" packet is sent on session close. 2) UDP sockets are bound to only one interface, which IP is retrieved from already connected RTSP session. This improves security in certain usage scenarios, especially with multicast. new features: 1) UDP multicast support. New SETUP request asking for multicast. New socket extension for multicast groups. Implementation logic is similar to FFMPEG "forced multicast" or VLC --rtsp-mcast option. todo: 0) Unit tests update (if needed?) 1) so far tested on only one device - TRUEN HD encoder 2) Transport Protocol may be selected based on device capabilities (AUTO option?) Contained in no branch Contained in no tag Derives from tag: 1.1 + 52 commits
|
Test on different PC and two different video encoders. Found small problem with IPv6 addresses, but already fixed it in third commit. |
…ackets are sent to unicast IP of source (rfc5760)
Revan1985
pushed a commit
to Revan1985/RtspClientSharp
that referenced
this pull request
Nov 28, 2023
…vKirill#125 from BogdanovKirill/RtspClientSharp repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fixes:
Fixed.
Fixed.
Fixed.
I added WithCancellation task extension and now ReadAsync can be canceled immediately without wait for next incoming packet. I modified only UDP part, but extension can be used in other places too.
improvements:
new features:
Implementation logic is similar to FFMPEG "forced multicast" or VLC --rtsp-mcast option.
todo: