BUG: Fix STLFileReader crash bug #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imikejackson
commented
Apr 26, 2024
imikejackson
commented
- Original bug was caused by a malformed fmt::format statement with a mismatch '}' character.
- Added more error checking to ensure we can safely recover from common STL reading errors
- Updated the documentation to reflect the vendor list that does not write conformant STL Files.
imikejackson
force-pushed
the
topic/stl_file_read_crash
branch
from
2fd18bd
to
3c41d35
Compare
nyoungbq
approved these changes
Apr 26, 2024
- Original bug was caused by a malformed fmt::format statement with a mismatch '}' character. - Added more error checking to ensure we can safely recover from common STL reading errors - Updated the documentation to reflect the vendor list that does not write conformant STL Files. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/stl_file_read_crash
branch
from
3c41d35
to
cf5dca1
Compare
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/stl_file_read_crash
branch
from
e597e9f
to
008188d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.