Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
these were reverted changes that got missed after the renaming rebase

Co-authored-by: Matthew Marine <matthew.marine@bluequartz.net>
  • Loading branch information
nyoungbq and mmarineBlueQuartz committed May 1, 2024
1 parent 6384ad7 commit 0ecdb4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ class IOHandler
// rename grayscale array to reflect original
{
auto& gray = m_DataStructure.getDataRefAs<IDataArray>(imageDataPath.replaceName("gray" + imageDataPath.getTargetName()));
if(gray.canRename(imageDataPath.getTargetName()) != 1)
if(gray.canRename(imageDataPath.getTargetName()) == false)
{
return MakeErrorResult(-18543, fmt::format("Unable to rename the grayscale array to {}", imageDataPath.getTargetName()));
}
Expand Down
2 changes: 1 addition & 1 deletion src/simplnx/DataStructure/DataObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class SIMPLNX_EXPORT DataObject
* @brief Checks and returns if the DataObject can be renamed to the provided
* value.
* @param name
* @return int: 0 = false, 1 = true, 2 = duplicate object found
* @return bool
*/
bool canRename(const std::string& name) const;

Expand Down

0 comments on commit 0ecdb4c

Please sign in to comment.