Change block audio to mono for positional audio. #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts Crusher, Diesel Generator, Breaker Switch, and Metal Press sounds to mono for positional audio. (Other audio may still need to be changed as mentioned in #4524.)
This does not make turret sounds positional, as that would also alter the way the revolver sounds when fired. Nor does it make any other audio positional, even when they could be, as they'd have other impacts or I'm not sure if they should be made positional yet.
This is my very first pull request ever for anything, so I'm trying to be as conservative as possible. This probably should NOT close the related issue.
This likely will have a knock-on effect of making a diesel generator and other blocks much quieter in-game, due to it no longer effectively playing inside the player's head. I'm guessing this can/would be addressed through changes to volume values in the code? I think I can see where to make those changes, but again I'm being conservative.