Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of recipes in PacketBuffer's #4387

Open
wants to merge 5 commits into
base: 1.15
Choose a base branch
from

Conversation

malte0811
Copy link
Collaborator

No description provided.

@BluSunrize
Copy link
Owner

I understand that this is a quick fix to the recipes added by IE, but shouldn't issues with vanilla shaped recipes be handled in Forge instead?

@malte0811
Copy link
Collaborator Author

No, Forge servers need to be compatible with vanilla clients and vice versa. With this changed format that isn't (easily?) possible.

@BluSunrize
Copy link
Owner

BluSunrize commented Oct 18, 2020

Ah! I was unaware/ignorant of the fact that Forge and Vanilla required compatability.
That said, Compressed Recipes could still be a part of Forge's framework, much like ShapedOre and ShapelessOre recipes were in past iterations, no?
I'm not looking to dismantle this PR, I'm all for reducing the packet size, I'm just thinking that it would be good to standardize this across the modded community!

@BluSunrize
Copy link
Owner

@malte0811 Are you still looking to have this implemented?

@malte0811
Copy link
Collaborator Author

Probably some parts of it, but not everything. Some things are optimized much better in RecipeBuffers than they can be here, but other things I can't really influence from outside IE. I'll remove the parts that I don't want any more when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants