New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of recipes in PacketBuffer's #4387
base: 1.15
Are you sure you want to change the base?
Conversation
…as we essentially never see numbers large enough for Int to be more efficient than VarInt
…nts and use it for recipes where it significantly reduces size
I understand that this is a quick fix to the recipes added by IE, but shouldn't issues with vanilla shaped recipes be handled in Forge instead? |
No, Forge servers need to be compatible with vanilla clients and vice versa. With this changed format that isn't (easily?) possible. |
Ah! I was unaware/ignorant of the fact that Forge and Vanilla required compatability. |
@malte0811 Are you still looking to have this implemented? |
Probably some parts of it, but not everything. Some things are optimized much better in RecipeBuffers than they can be here, but other things I can't really influence from outside IE. I'll remove the parts that I don't want any more when I have some time. |
No description provided.