This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Fix GPO collection collecting versioning GPO when GPA is used #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I dont think I've run into this before, going to take a look and make sure everything works properly before merging |
|
Yep sure, ping me on slack if you need further information. |
rvazarkar
referenced
this pull request
in BloodHoundAD/SharpHound3
Nov 7, 2019
Fix based on PR from @Crypt0-M3lon BloodHoundAD/SharpHound#65
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My compagny use Group Policy Admin (https://www.microfocus.com/en-us/products/netiq-group-policy-administrator/overview) to manage GPO.
When collecting GPO, versionned GPO managed by GPA are collected, leading the the collect of 4 Default Domain Policy and wrong/false positive attack paths.
The main différence between a versionned GPO and an GPO is the presence of the Flags attributes in the Group Policy Object.
The patch just add a check for the flags attribute existence in LDAP queries to ignore versionned GPO.