Refactor apply_successful_verification: dead code #103
Conversation
- Makes all the code reachable but disabled - Renamed method for better readibility - Type hint that it returns `bool`
|
I had a look at the history of these disabled code blocks, and it looks like they were disabled shortly after being added. I think it is unlikely that someone will ever finish the job after 3 years of inactivity. I'm wondering if we couldn't just delete them. I feel like this suppresses a useful warning (dead code stinks) without really addressing the problem. If we remove it, we also remove the need to maintain it. |
|
On the other hand, I have not really tried to figure out what this code was supposed to do, so maybe I need to have another look later. |
Yes, I find it hard to understand. I know it's verifying a checkpoint, whatever that means. Is this for the checkpoint that BCH added during the BCH/BSV hashwar? |
Backport of Electron-Cash#2219.
boolRelated issue: Electron-Cash#2213
This change is