-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use optional chaining to fix error when windowId is undefined in Wayland #490
base: master
Are you sure you want to change the base?
Conversation
…ors when windowId is undefined in Wayland
This change indeed fixes (or works around?) issue #473 for me. Thanks! |
I just installed Bismuth from your branch on openSUSE Tumbleweed, but it makes the screen very glitchy and half-tiling doesn't work (only quarter tiling). And some apps don't open at all. |
That's odd, everything works perfectly on mine and I don't think the change would prevent any window that already opens from opening. Probably a different problem. |
Thanks, this is great! Please merge this and get it into the Arch repos so I don't have to keep manually building things. |
Thanks! Great work! That's helped |
Thank you so much! ❤️ How much a single symbol can do for humanity 😁 I built the RPM package for Fedora 38 from the official spec file, here you go, maybe someone will need it (the process of building from source code is a pain for a normal human, don't want others to suffer). |
This is a reimplementation of Bismuth-Forge#490 My esbuild and tsc on Debian Testing right now aren't smart enough to convert the ?. optional chaining into something that Qt 5.15 can understand.
Summary
On KWin Wayland (5.27.6), I noticed that bismuth is throwing the ff. error when tiling Firefox causing tiling to break so I investigated and was able to pinpoint the error. It turns out windowId is undefined for some apps so I changed it to optional chaining which fixed the problems I've been having with tiling.
Here's how it worked before this change (the other windows don't resize immediately, eventually they stop tiling altogether):
bismuth-broken.mp4
Here's how it worked after this change (the other windows resize immediately):
bismuth-working.mp4
Breaking Changes
Should not break anything.
UI Changes
None
Test Plan
a. The remaining windows should resize correctly
b. Previously, these windows don't resize as one of the handlers throws the above error and fails to process the event
Related Issues
Potentially closes #473 or at least fixes one problem related to wayland.