Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select the default layout #117

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

winiciuscota
Copy link

Really happy to know about this fork, I Adapted the changes from my pr in the original project.

Summary

Add option to select the default layout.

Test Plan

Open the config menu
Change the default layout
Assert that the configuration works

Preview

image

Related Issues

Closes #74

@gikari gikari self-requested a review October 18, 2021 16:39
Copy link
Member

@gikari gikari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unfortunate, that we have to duplicate the list of layouts, but this is the limitation of the current config system (will be improved with the in the future with the separate KCM (see #94)).

res/config/main.xml Outdated Show resolved Hide resolved
res/ui/config.ui Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@gikari
Copy link
Member

gikari commented Oct 20, 2021

JFYI, you need to fix pipeline errors to proceed :) In particular:

  • Rename commits (or better - merge them into one) according to the Conventional Commits spec
  • Fix Linting and Formatting errors.

@gikari
Copy link
Member

gikari commented Nov 3, 2021

Since 2.0 is released, you will have to adopt your merge request accordingly. In particular, the configuration is now done in a separate KCM, so you'll have to write some UI code.

@v3ss0n
Copy link

v3ss0n commented Dec 23, 2021

can i take over?

@gikari
Copy link
Member

gikari commented Dec 23, 2021

Yep.

@v3ss0n
Copy link

v3ss0n commented Dec 23, 2021

I will work on it tomorrow and make a separate PR.

@NyaomiDEV
Copy link

I'd hope that now that the KCM is there, we'd also be able to have a default layout per screen (as an example I have an ultrawide screen where I use three columns, and a normal 16:9 where I want to use normal tiling)

@BBaoVanC
Copy link

Is there any progress on this? This is a really important feature to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Default Layout
5 participants